Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packetdelay/jitter

From: Paolo Valente
Date: Tue Jul 16 2013 - 02:55:10 EST


Il 15/07/2013 20:12, Joe Perches ha scritto:
On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote:
QFQ+ inherits from QFQ a design choice that may cause a high packet
delay/jitter and a severe short-term unfairness.
[]
diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
[]
@@ -189,6 +188,7 @@ struct qfq_sched {
struct qfq_aggregate *in_serv_agg; /* Aggregate being served. */
u32 num_active_agg; /* Num. of active aggregates */
u32 wsum; /* weight sum */
+ unsigned long iwsum; /* inverse weight sum*/

This is a different size for 32/64 bit compiles
and may be better as u32.


Sending a new version with u32, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/