Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of highpacket delay/jitter

From: Joe Perches
Date: Mon Jul 15 2013 - 14:12:28 EST


On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote:
> QFQ+ inherits from QFQ a design choice that may cause a high packet
> delay/jitter and a severe short-term unfairness.
[]
> diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
[]
> @@ -189,6 +188,7 @@ struct qfq_sched {
> struct qfq_aggregate *in_serv_agg; /* Aggregate being served. */
> u32 num_active_agg; /* Num. of active aggregates */
> u32 wsum; /* weight sum */
> + unsigned long iwsum; /* inverse weight sum*/

This is a different size for 32/64 bit compiles
and may be better as u32.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/