Re: [PATCH 2/3] arm: atmel: at91sam9n12: add qt1070 support

[Bo Shen]

Hi J,

On 7/10/2013 22:38, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:51 Wed 10 Jul     , Bo Shen wrote:
> > add qt1070 support on at91sam9n12ek board
> >
> > Signed-off-by: Bo Shen <voice.shen@xxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/at91sam9n12ek.dts |   16 ++++++++++++++++
> >   1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> > index d59b70c..3acac62 100644
> > --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> > @@ -40,6 +40,15 @@
> >
> >   			i2c0: i2c@f8010000 {
> >   				status = "okay";
> > +
> > +				qt1070: keyboard@1b {
> > +					compatible = "qt1070";
> > +					reg = <0x1b>;
> > +					interrupt-parent = <&pioA>;
> > +					interrupts = <2 0x0>;
> use the macro

Thanks, I will use macro here.

> > +					pinctrl-names = "default";
> > +					pinctrl-0 = <&pinctrl_qt1070_irq>;
> > +				};
> >   			};
> >
> >   			i2c1: i2c@f8014000 {
> > @@ -66,6 +75,13 @@
> >   							<AT91_PIOA 7 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;	/* PA7 gpio CD pin pull up and deglitch */
> >   					};
> >   				};
> > +
> > +				qt1070 {
> > +					pinctrl_qt1070_irq: qt1070_irq {
> > +						atmel,pins =
> > +							<AT91_PIOA 2 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; /* PA2 GPIO with pull up deglith */
> drop the comment as we use macro

OK, I will drop the comment

> > +					};
> > +				};
> >   			};
> >
> >   			spi0: spi@f0000000 {
> > --
>
> Best Regards,
> J.

Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/