Re: [PATCH 5/6] sysfs: add support for binary attributes in groups

[Greg Kroah-Hartman]

On Wed, Jul 10, 2013 at 04:00:57PM -0700, Guenter Roeck wrote:
> On Wed, Jul 10, 2013 at 01:05:13PM -0700, Greg Kroah-Hartman wrote:
> > @@ -52,6 +55,17 @@ static int create_files(struct sysfs_dirent *dir_sd, struct kobject *kobj,
> >  	}
> >  	if (error)
> >  		remove_files(dir_sd, kobj, grp);
> 
> You might want to abort here if there was an error.

Good point, I'll update it.

> > +
> > +	for (bin_attr = grp->bin_attrs; *bin_attr; bin_attr++) {
> 
> What happens here if grp->bin_attrs is NULL ? Doesn't that cause a NULL
> reference when accessing *bin_attr ?
> 
> [ The problem didn't exist before since attr was supposed to be non-NULL.
>   It may now be a problem if only bin_attr is provided, ie if there are
>   only binary attribute files.
>   Or maybe I am just tired and there is no problem... ]

I thought I tested this patch out, but I think you are right, let me go
do a rebuild and test it again...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/