[PATCH 1/3] firmware/dmi_scan: Drop obsolete comment

From: Jean Delvare
Date: Tue Jul 09 2013 - 11:41:56 EST


This comment predates the introduction of early_ioremap. Since then
the missing calls to dmi_iounmap have been added by Ingo and Yinghai
in commits 0d64484f7ea12ca04211b497e94634c3d27cf3fb and
3212bff370c2f22e4987c6679ba485654cefb178. That was over 5 years ago so
it is about time to drop this now misleading comment.

Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Yinghai Lu <yinghai@xxxxxxxxxx>
---
drivers/firmware/dmi_scan.c | 5 -----
1 file changed, 5 deletions(-)

--- linux-3.10-rc0.orig/drivers/firmware/dmi_scan.c 2013-05-04 11:16:44.229314442 +0200
+++ linux-3.10-rc0/drivers/firmware/dmi_scan.c 2013-05-04 11:19:17.320935301 +0200
@@ -497,11 +497,6 @@ void __init dmi_scan_machine(void)
}
}
else {
- /*
- * no iounmap() for that ioremap(); it would be a no-op, but
- * it's so early in setup that sucker gets confused into doing
- * what it shouldn't if we actually call it.
- */
p = dmi_ioremap(0xF0000, 0x10000);
if (p == NULL)
goto error;


--
Jean Delvare
Suse L3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/