Re: [PATCH RFC] fsio: filesystem io accounting cgroup
From: Konstantin Khlebnikov
Date: Tue Jul 09 2013 - 10:36:05 EST
Tejun Heo wrote:
On Tue, Jul 09, 2013 at 05:43:10PM +0400, Konstantin Khlebnikov wrote:
My concept it cgroup which would control io operation on vfs layer
for all filesystems. It will account and manage IO operations. I've
found really lightweight technique for accounting and throttling
which don't introduce new locks or priority inversions (which is
major problem in all existing throttlers, including cpu cgroup rate
limiter) So, I've tried to keep code smaller, cleaner and saner as
possible while you guys are trying to push me into the block layer
=)
You're trying to implement QoS in the place where you don't have
control of the queue itself. You aren't even managing the right type
of resource for disks which is time slice rather than iops or
bandwidth and by the time you implemented proper hierarchy support and
proportional control, yours isn't gonna be that simple either. The
root problem is bdi failing to propagate pressure from the actual
queue upwards. Fix that.
I'm not interested in QoS or proportional control. Let schedulers do it.
I want just bandwidth control. I don't want to write a new scheduler
or extend some of existing one. I want implement simple and lightweight
accounting and add couple of throttlers on top of that.
It can be easily done without violation of that hierarchical design.
The same problem already has happened with cpu scheduler. It has really
complicated rate limiter which is actually useless in the real world because
it triggers all possible priority inversions since it puts bunch of tasks into
deep sleep while some of them may hold kernel locks. Perfect.
QoS and scheduling policy are good thing, but rate-limiting must be separated
and done only in places where it doesn't leads to these problems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/