Re: [RFC PATCH] tracing/kprobe: Wait for disabling all running kprobehandlers

[Masami Hiramatsu]

(2013/07/09 17:21), Peter Zijlstra wrote:
> On Tue, Jul 09, 2013 at 05:20:17PM +0900, Masami Hiramatsu wrote:
>> (2013/07/09 17:07), Peter Zijlstra wrote:
>>> On Tue, Jul 09, 2013 at 05:01:45PM +0900, Masami Hiramatsu wrote:
>>>> +	if (wait) {
>>>> +		/*
>>>> +		 * synchronize with kprobe_trace_func/kretprobe_trace_func
>>>> +		 * to ensure disabled (all running handlers are finished)
>>>> +		 */
>>>> +		synchronize_sched();
>>>> +		kfree(link);	/* Ignored if link == NULL */
>>>> +	}
>>>
>>> What's not clear to me from this comment is if we're only waiting for kfree()?
>>> In that case shouldn't we use call_rcu() to free the thing? Or do we need the
>>> sync_sched() for other purposes as well?
>>
>> No, this is not only for kfree, but also to ensure completing
>> disabling process, because trace_remove_event_call() supposes
>> that for releasing event_call related objects (Those objects
>> will be accessed in the handlers).
> 
> Then may I kindly suggest you clarify this in the comment? :-)
> 

Ah, right! I'll update it :)

Thank you!

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/