Re: [PATCH RFC] fsio: filesystem io accounting cgroup

From: Tejun Heo
Date: Mon Jul 08 2013 - 13:00:57 EST


(cc'ing Vivek and Jens)

Hello,

On Mon, Jul 08, 2013 at 02:01:39PM +0400, Konstantin Khlebnikov wrote:
> This is proof of concept, just basic functionality for IO controller.
> This cgroup will control filesystem usage on vfs layer, it's main goal is
> bandwidth control. It's supposed to be much more lightweight than memcg/blkio.

While blkcg is pretty heavy handed right now, there's no inherent
reason for it to be that way. The right thing to do would be updating
blkcg to be light-weight rather than adding yet another controller.
Also, all controllers should support full hierarchy.

> Unlike to blkio this method works for all of filesystems, not just disk-backed.
> Also it's able to handle writeback, because each inode has context which can be
> used in writeback thread to account io operations.

Again, a problem to be fixed in the stack rather than patching up from
up above. The right thing to do is to propagate pressure through bdi
properly and let whatever is backing the bdi generate appropriate
amount of pressure, be that disk or network.

> This is early prototype, I have some plans about extra functionality because
> this accounting itself is mostly useless, but it can be used as basis for more
> usefull features.

I'm afraid it'd have very low chance of making upstream. If this area
of work is interesting / important, please look into improving blkcg
rather than working around it.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/