Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation

From: Mark Brown
Date: Mon Jul 08 2013 - 10:50:22 EST


On Mon, Jul 08, 2013 at 03:29:16PM +0200, Michal Simek wrote:
> Use devm_request_irq() for irq allocation which
> simplify driver code.

> @@ -495,7 +493,6 @@ static int xilinx_spi_remove(struct platform_device *pdev)
> struct xilinx_spi *xspi = platform_get_drvdata(pdev);
>
> spi_bitbang_stop(&xspi->bitbang);
> - free_irq(xspi->irq, xspi);
>
> spi_master_put(xspi->bitbang.master);

Is it definitely safe to leave the IRQ hanging around after the master
has been freed - there's no possibility of a late error interrupt or
something?

Attachment: signature.asc
Description: Digital signature