Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

[Greg KH]

On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote:
> On Tue, Jul 02, 2013 at 07:27:49PM +0000, Linux Kernel wrote:
>  > Gitweb:     http://git.kernel.org/linus/;a=commit;h=d05c39ea67f5786a549ac9d672d2951992b658c6
>  > Commit:     d05c39ea67f5786a549ac9d672d2951992b658c6
>  > Parent:     a3b2c8c7aa1ca860edcf0b0afa371d9eb2269c3c
>  > Author:     Takashi Iwai <tiwai@xxxxxxx>
>  > AuthorDate: Wed May 22 18:28:37 2013 +0200
>  > Committer:  Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>  > CommitDate: Mon Jun 3 13:57:29 2013 -0700
>  > 
>  >     dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly
>  >     
>  >     The usermode helper is mandatory for this driver.
>  >     
>  >     Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
>  >     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>  > ---
>  >  drivers/firmware/Kconfig |    1 +
>  >  1 files changed, 1 insertions(+), 0 deletions(-)
>  > 
>  > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>  > index 9387630..0747872 100644
>  > --- a/drivers/firmware/Kconfig
>  > +++ b/drivers/firmware/Kconfig
>  > @@ -64,6 +64,7 @@ config DELL_RBU
>  >  	tristate "BIOS update support for DELL systems via sysfs"
>  >  	depends on X86
>  >  	select FW_LOADER
>  > +	select FW_LOADER_USER_HELPER
>  >  	help
>  >  	 Say m if you want to have the option of updating the BIOS for your
>  >  	 DELL system. Note you need a Dell OpenManage or Dell Update package (DUP)
> 
> 
> This is pretty crappy. Now every distro kernel has to have that enabled,
> which screws up for eg, the x86 microcode driver. (It takes 1 minute per cpu
> when this is enabled).

I'll let you and Takashi battle this one out, for some reason I thought
he added it _because_ a distro kernel needed it...

Takashi?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/