Re: [RFC PATCH 3/5] hwmon: (ds1621) Convert to use hwmon_device_register_groups

From: Jean Delvare
Date: Sat Jul 06 2013 - 15:55:18 EST


On Sat, 6 Jul 2013 12:31:42 -0700, Greg Kroah-Hartman wrote:
> On Sat, Jul 06, 2013 at 12:18:16PM -0700, Guenter Roeck wrote:
> > Yes, and I tested it with the new nct6775 driver to make sure that it works.
> > The i2c and spi drivers need some more work, though - the name attribute is
> > now missing and will have to be created for the hwmon device itself. If you have
> > an idea how to do that without adding it in every driver, please let me know.
>
> Why do you need a name attribute at all? Shouldn't that just be the
> name of the device, or the parent?

libsensors expects the hwmon attributes and the name attribute at the
same place.

> Can you make the name be part of the groups always?

Sounds good, but then we have to make the hwmon core handles it. So far
each driver (or its bus type subsystem) was responsible for it.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/