Re: [PATCH v5 00/12] Lockless update of reference count protected byspinlock

From: Al Viro
Date: Fri Jul 05 2013 - 13:55:43 EST


On Fri, Jul 05, 2013 at 11:29:10AM -0400, Waiman Long wrote:
> >I've just pushed such commit into vfs.git#for-linus; please, do the rest
> >on top of it. And keep it bisectable, i.e. so that at any intermediate
> >point the tree would build and work.
>
> I am sorry. I didn't change anything in the dentry structure in
> patch 3. So putting patches 4-11 on top of it won't break the build.

*gyah*... I'd missed the !@#!# macro you've added there. Could you
explain the reasons for using it at all? Not to mention anything
else, you've missed
# define d_refcount(d) ((d)->d_count)
in Lustre. What's the point of your macro (d_refcount -> d_count), anyway?
All references outside of fs/namei.c, fs/dcache.c, include/linux/dcache.h
should be via d_count(dentry) anyway...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/