Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Update driver name tofix breakage due to pmic driver with same name

From: Mark Brown
Date: Fri Jul 05 2013 - 09:38:17 EST


On Fri, Jul 05, 2013 at 07:05:06PM +0530, Ashish Chavan wrote:
> On Fri, 2013-07-05 at 12:44 +0100, Mark Brown wrote:

> > > static const struct i2c_device_id da9055_i2c_id[] = {
> > > - { "da9055", 0 },
> > > + { "da9055-codec", 0 },
> > > { }
> > > };

> > I can't believe that you've tested this.

> Yes, I have tested this today only. But with 3.6.0-rc4 kernel. That is
> the newest kernel for which I have board and other required support
> available.

Your testing seems like it's not very good then - you do undersand that
the problem that this is supposed to be fixing is that this is a multi
function device? Please look at how other MFDs in the kernel work.

Attachment: signature.asc
Description: Digital signature