Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate

From: Denys Vlasenko
Date: Thu Jul 04 2013 - 05:04:09 EST


On Tue, Jul 2, 2013 at 10:01 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> On 07/01, Denys Vlasenko wrote:
>>
>> Grepping for numeric constants is inconvenient.
>
> Personally I agree very much, and I like the intent.
>
>> +#define WTERMSIG_MASK 0x7f
>> +#define WTERMSIG(status) ((status) & WTERMSIG_MASK)
>> +#define WCOREDUMP(status) ((status) & 0x80)
>
> But I am not sure we need WTERMSIG/WCOREDUMP helpers, although
> I won't really argue.

Are you saying that you prefer just mask constants,
do not want macros?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/