Re: [PATCH] HID: kye: Add report fixup for Genius Gila Gamingmouse
From: Jiri Kosina
Date: Wed Jul 03 2013 - 12:17:05 EST
On Tue, 2 Jul 2013, Benjamin Tissoires wrote:
> Genius Gila Gaming Mouse presents an obviously wrong report descriptor.
> the Consumer control (report ID 3) is the following:
> 0x05, 0x0c, // Usage Page (Consumer Devices) 105
> 0x09, 0x01, // Usage (Consumer Control) 107
> 0xa1, 0x01, // Collection (Application) 109
> 0x85, 0x03, // Report ID (3) 111
> 0x19, 0x00, // Usage Minimum (0) 113
> 0x2a, 0xff, 0x7f, // Usage Maximum (32767) 115
> 0x15, 0x00, // Logical Minimum (0) 118
> 0x26, 0xff, 0x7f, // Logical Maximum (32767) 120
> 0x75, 0x10, // Report Size (16) 123
> 0x95, 0x03, // Report Count (3) 125
> 0x81, 0x00, // Input (Data,Arr,Abs) 127
> 0x75, 0x08, // Report Size (8) 129
> 0x95, 0x01, // Report Count (1) 131
> 0x81, 0x01, // Input (Cnst,Arr,Abs) 133
> 0xc0, // End Collection 135
>
> So the first input whithin this report has a count of 3 but a usage range
> of 32768. So this value is obviously wrong as it should not be greater than
> the report count.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=959721
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> ---
> Hi Jiri,
>
> I know the window just opened and you don't really like receiving patches at
> that time. Still, my patch queue is growing, and I would like you to consider
> this patch for 3.11.
This one is really easy enough to go into even post -rc1 :) Now applied
for the Linus merge I am going to do shortly.
Thanks a lot, Benjamin.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/