From 3e7859206c8298b58779a6e200747ae48a02149c Mon Sep 17 00:00:00 2001 From: Sedat Dilek Date: Wed, 3 Jul 2013 12:45:40 +0200 Subject: [PATCH next-20130703] memcg: Fix build failure in mem_cgroup_css_free() From my build-log for next-20130703: ... mm/built-in.o: In function `mem_cgroup_css_free': memcontrol.c:(.text+0x5caa6): undefined reference to `mem_cgroup_sockets_destroy' make[2]: *** [vmlinux] Error commit 49f2b6beb428 ("memcg: use css_get/put when charging/uncharging kmem") renamed kmem_cgroup_destroy() to kmem_cgroup_css_offline(). -static void kmem_cgroup_destroy(struct mem_cgroup *memcg) +static void kmem_cgroup_css_offline(struct mem_cgroup *memcg) Whereas in mem_cgroup_css_free() I see this: - kmem_cgroup_destroy(memcg); + mem_cgroup_sockets_destroy(memcg); This should be IMHO: + kmem_cgroup_css_offlinememcg); I am not sure if this was intended and speculate this is a typo. This patch tries to fix the issue. Signed-off-by: Sedat Dilek --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d6a3e56..ca8d985 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6332,7 +6332,7 @@ static void mem_cgroup_css_free(struct cgroup *cont) { struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); - mem_cgroup_sockets_destroy(memcg); + mem_cgroup_css_offline(memcg); __mem_cgroup_free(memcg); } -- 1.8.3.2