Re: [PATCH] metag: move EXPORT_SYMBOLs in libs to metag_ksyms.c

[Rusty Russell]

James Hogan <james.hogan@xxxxxxxxxx> writes:
> Move all EXPORT_SYMBOLs in libs-y directories (arch/metag/{lib,tbx})
> into metag_ksyms.c so that they don't get omitted by the static linker
> if they're not used by any other statically linked code, which can
> result in undefined symbols when building modules.
>
> For example a randconfig caused the following error:
> ERROR: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
>
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> ---
> Unless there are any objections I'll apply this patch for v3.11. I'm
> assuming *_ksyms.c is the way that this problem is normally worked
> around.

Actually, normally those files are obj-y not lib-y.  See the top-level
lib/.

Subtle, I know.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/