Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree

From: Luciano Coelho
Date: Tue Jul 02 2013 - 16:20:34 EST


On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote:
> > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func,
> > /* Use block mode for transferring over one block size of data */
> > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE;
> >
> > + sdio_set_drvdata(func, glue);
>
> is this move really necessary ?

It is, because I use the glue in wlcore_get_pdata_from_of(), so I need
to call sdio_set_drvdata() earlier. I reckoned it wouldn't hurt to move
this, so I wouldn't have to pass the glue in the
wlcore_get_pdata_from_of() call.

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/