Re: [PATCH v2 4/4] usb: ohci-ep93xx: tidy up driver (*probe) and(*remove)

From: Alan Stern
Date: Tue Jul 02 2013 - 11:08:18 EST


On Mon, 1 Jul 2013, H Hartley Sweeten wrote:

> Merge the usb_hcd_ep93xx_probe() into ohci_hcd_ep93xx_drv_probe() and
> the usb_hcd_ep93xx_remove() into ohci_hcd_ep93xx_drv_remove(). As Alan
> Stern pointed out, there is no reason for them to be separate.
>
> Also, as Alan Stern suggested, eliminate the ep93xx_start_hc() and
> ep93xx_stop_hc() routines and simply call clk_enable() and clk_disable()
> directly. The extra level of redirection does not add any clarity.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/