Re: [PATCH 1/3] mm/slub: Fix slub calculate active slabsuncorrectly

[Christoph Lameter]

On Tue, 2 Jul 2013, Wanpeng Li wrote:

> Before patch:
> Active / Total Slabs (% used) : 59018 / 59018 (100.0%)
>
> After patch:
> Active / Total Slabs (% used) : 11086 / 11153 (99.4%)

Yes I saw that.

> These numbers are dump from slabtop for monitor slub, before patch Active / Total
> Slabs are always 100%, this is not truth since empty slabs present. However, the
> slab allocator can caculate its Active / Total Slabs correctly and its value is
> less than 100.0%. By comparison, slub is more efficient than slab through slabtop
> observation, however, it is not truth since slub uncorrectly calculate its
> Active / Total Slabs.

I always thought about the "empty" slabs to be active since they are used
for allocation and frees like the other partial slabs.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/