Re: [PATCHv2] drivers: spi: Add qspi flash controller

From: Mark Brown
Date: Tue Jul 02 2013 - 06:17:47 EST


On Tue, Jul 02, 2013 at 12:44:04PM +0300, Felipe Balbi wrote:
> On Tue, Jul 02, 2013 at 10:32:47AM +0100, Mark Brown wrote:

> > Does this hardware really support anything other than 8 bits per word?
> > There is no code in the driver which pays any attention to the word
> > size...

> the HW has a 128-bit shift register ;-) but driver doesn't look
> complete.

That's not the issue - remember that SPI specifies big endian byte
ordering for words on the bus so things will need to be reordered by the
hardware for anything except 8 bits.

Attachment: signature.asc
Description: Digital signature