RE: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events

[Hebbar, Gururaja]

On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote:
> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote:
> > On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
> > is available to enable Alarm Wakeup feature. This register needs to be
> > properly handled for the rtcwake to work properly.
> > 
> > Platforms using such IP should set "ti,am3352-rtc" in rtc device dt
> > compatibility node.
> > 
> > Signed-off-by: Hebbar Gururaja <gururaja.hebbar@xxxxxx>
> > Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> > Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> > Cc: Rob Landley <rob@xxxxxxxxxxx>
> > Cc: Sekhar Nori <nsekhar@xxxxxx>
> > Cc: Kevin Hilman <khilman@xxxxxxxxxx>
> > Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> > Cc: rtc-linux@xxxxxxxxxxxxxxxx
> > Cc: devicetree-discuss@xxxxxxxxxxxxxxxx
> > Cc: linux-doc@xxxxxxxxxxxxxxx
> > ---
> 
> [...]
> 
> > -#define	OMAP_RTC_DATA_DA830_IDX	1
> > +#define	OMAP_RTC_DATA_DA830_IDX		1
> > +#define	OMAP_RTC_DATA_AM335X_IDX	2
> >  
> >  static struct platform_device_id omap_rtc_devtype[] = {
> >  	{
> > @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = {
> >  	}, {
> >  		.name	= "da830-rtc",
> >  		.driver_data = OMAP_RTC_HAS_KICKER,
> > +	}, {
> > +		.name	= "am335x-rtc",
> 
> may be use am3352-rtc here just to keep the platform device name and of
> compatible in sync.

Correct. I will update the same in v2.

> 
> > +		.driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN,
> >  	},
> >  	{},
> 
> It is better to use the index defined above in the static initialization
> so they remain in sync.

Sorry. I didnât get this.

> 
> 	...
> 	[OMAP_RTC_DATA_DA830_IDX] = {
> 		.name	= "da830-rtc",
> 		.driver_data = OMAP_RTC_HAS_KICKER,
> 	},
> 	...
> 
> >  };
> > @@ -318,6 +333,9 @@ static const struct of_device_id omap_rtc_of_match[] = {
> >  	{	.compatible	= "ti,da830-rtc",
> >  		.data		= &omap_rtc_devtype[OMAP_RTC_DATA_DA830_IDX],
> >  	},
> > +	{	.compatible	= "ti,am3352-rtc",
> > +		.data		= &omap_rtc_devtype[OMAP_RTC_DATA_AM335X_IDX],
> > +	},
> >  	{},
> >  };
> >  MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
> 
> Apart from these minor issues, the patch looks good to me.
> 
> Acked-by: Sekhar Nori <nsekhar@xxxxxx>
> 
> Thanks,
> Sekhar
> 


Regards, 
Gururaja
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_