Re: [PATCH 5/9] usb: phy: tegra: Register as an USB PHY.

[Stephen Warren]

On 06/28/2013 03:37 PM, Tuomas Tynkkynen wrote:
> Register the Tegra PHY device instances with the PHY subsystem so that
> the Tegra EHCI driver can locate a PHY via the standard APIs.

> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c

> +	err = usb_add_phy_dev(&tegra_phy->u_phy);
> +	if (err < 0) {
> +		tegra_usb_phy_close(&tegra_phy->u_phy);
> +		return err;
> +	}

Don't you want to do that a bit later? In particular ...

>  	tegra_phy->u_phy.shutdown = tegra_usb_phy_close;
>  	tegra_phy->u_phy.set_suspend = tegra_usb_phy_suspend;
> 
> 	dev_set_drvdata(&pdev->dev, tegra_phy);

... that all happens *after* the call to usb_add_phy_dev() call, yet I
think the USB core could legally call any of the PHY methods after the
call to usb_add_phy_dev(), and that probably requires all those methods
pointers and drvdata to be set up? I suggest moving the call to
usb_add_phy_dev() to the very end of the function.

> +static int tegra_usb_phy_remove(struct platform_device *pdev)
> +{
> +	struct tegra_usb_phy *tegra_phy = platform_get_drvdata(pdev);
> +
> +	usb_remove_phy(&tegra_phy->u_phy);
> +	return 0;
> +}

Nit: I'd typically expect to see a blank line before the return statement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/