Re: [PATCH net-next 0/2] net: lls cleanup patches

From: David Miller
Date: Mon Jul 01 2013 - 17:08:41 EST


From: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
Date: Fri, 28 Jun 2013 15:59:18 +0300

> Here are two cleanup patches.
>
> 1. fix warning from debug_smp_processor_id().
> - reported by Cody P Schafer.
>
> 2. avoid calling sched_clock() in select and poll when lls is disabled.
> - reported by Andi Kleen.
>
> Thanks to everyone for their comments.

Applied, but like Ben said perhaps you want to remember the last cpu you
got the sched_clock() measurement from and abort the ll poll if it changes
on you instead of using a comparison between two cpus.

But then again, since preemption is enabled, the cpu could change
back and forth during the sched_clock() call, so you wouldn't be able
to reliably detect this anyways.

In the grand scheme of things all of this probably doesn't matter at
all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/