Re: [RFC] wlcore: sdio: add wilink clock providers

[Felipe Balbi]

Hi,

On Mon, Jul 01, 2013 at 10:34:10PM +0300, Luciano Coelho wrote:
> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> index 670c3ce..7f061b8 100644
> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
> @@ -65,11 +65,19 @@
>  		enable-active-high;
>  	};
>  
> +
>  	wlan {
> -	     compatible = "ti,wilink6";
> -	     interrupt-parent = <&gpio2>;
> -	     interrupts = <21 0x4>;	/* gpio line 53, high level triggered */
> -	     refclock = <2>;		/* 38.4 MHz */
> +		compatible = "ti,wilink6";
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <21 0x4>;	/* gpio line 53, high level triggered */
> +		clocks = <&refclock>;
> +		clock-names = "refclock";

hmmm, shouldn't you provide both clocks (refclock and tcx0clock)
explicitly here ?

Also, you should probably make it clear that the WiLink module is fed by
the 32K sync clock just to make sure clock usecounts are correctly
incremented ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature