Re: [PATCH v2 03/11] tracing: add soft disable for syscall events

From: Masami Hiramatsu
Date: Mon Jul 01 2013 - 07:26:12 EST


Hi Tom,

(2013/06/29 14:08), Tom Zanussi wrote:
> Add support for SOFT_DISABLE to syscall events.
>
> The original SOFT_DISABLE patches didn't add support for soft disable
> of syscall events; this adds it and paves the way for future patches
> allowing triggers to be added to syscall events, since triggers are
> built on top of SOFT_DISABLE.
>
> The existing code grabs the trace_array from the ftrace_file passed to
> the event registration functions and passes that to the probe
> functions. Passing the file instead allows the probe functions to
> access not only the trace_array attached to the file but the flags as
> well.

Hmm, this is not so simple. Syscall trace events are special events which
uses refcount and bitmap to identify syscall metadata, and only the first
enable request is passed for registering event handler.
Perhaps, we need to introduce a soft-disabled bitmap for tr or soft-disabled
bitflag for each syscall metadata.

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/