Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is notavailable

From: Felipe Balbi
Date: Sun Jun 30 2013 - 04:21:19 EST


Hi,

On Fri, Jun 28, 2013 at 10:06:01PM +0200, Michael Grzeschik wrote:
> > > > > > > > right, but in DT you will define both instances and each instance will
> > > > > > > > have a seaparate snps,maximum_speed attribute :-)
> > > > > > > >
> > > > > > > > I'm now considering if we should make maximum_speed a generic attribute,
> > > > > > > > Kishon ? Alex ? Alan ?
> > > > > > > >
> > > > > > > > anyone else needs such thing ?
> > > > > > >
> > > > > > > We have a force-full-speed attibute for chipidea on the way. This
> > > > > > > maximum_speed looks like a more generic alternative. Michael, what say
> > > > > > > you?
> > > > > >
> > > > > > The maximum_speed attribute sounds more reasonable. I will change my
> > > > > > patch to it.
> > > > >
> > > > > thanks, perhaps we can add a generic helper in udc-core or usb-common ?
> > > >
> > > > As this function is not only udc specific, this should go into usb-common.
> > > > But right, we should go with a helper here. I will write one in addition
> > > > to my full-speed patch as first user of it.
> > >
> > > alright, thanks :-)
> >
> > Michael, if you need any help with patching in maximum_speed attribute,
> > let me know as I have some time to work on that part.
>
> Feel free to begin with anything. I am currently short on time.
> Do you need some pointers?

not, really v1 will come on monday.

--
balbi

Attachment: signature.asc
Description: Digital signature