Re: Linux 3.10-rc7

[Sergey Meirovich]

Hi Linus,

On 29 June 2013 21:11, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Jun 29, 2013 at 8:05 AM, Sergey Meirovich <rathamahata@xxxxxxxxx> wrote:
>>
>> 3.10-rc7 doesn't compile for me
>>
>> rathamahata@piledriver /usr/local/src/linux-3.10-rc7 $ make -j1 bzImage modules
>> make[1]: Nothing to be done for `all'.
>> make[1]: Nothing to be done for `relocs'.
>>   CHK     include/generated/uapi/linux/version.h
>>   CHK     include/generated/utsrelease.h
>>   CALL    scripts/checksyscalls.sh
>>   CC      scripts/mod/devicetable-offsets.s
>>   GEN     scripts/mod/devicetable-offsets.h
>>   HOSTCC  scripts/mod/file2alias.o
>>   HOSTLD  scripts/mod/modpost
>>   CHK     include/generated/compile.h
>> make[3]: `arch/x86/realmode/rm/realmode.bin' is up to date.
>>   CC      drivers/gpu/drm/radeon/r200.o
>> drivers/gpu/drm/radeon/r200.c: In function âr200_set_safe_registersâ:
>> drivers/gpu/drm/radeon/r200.c:546:34: error: âr200_reg_safe_bmâ
>> undeclared (first use in this function)
>>   rdev->config.r100.reg_safe_bm = r200_reg_safe_bm;
>>                                   ^
>> drivers/gpu/drm/radeon/r200.c:546:34: note: each undeclared identifier
>
> Hmm. Your config builds here fine.
>
> What does your
>
>    drivers/gpu/drm/radeon/r200_reg_safe.h
>
> file look like?

This file is empty:
rathamahata@piledriver /usr/local/src/linux-3.10-rc7 $ cat
drivers/gpu/drm/radeon/r200_reg_safe.h
rathamahata@piledriver /usr/local/src/linux-3.10-rc7 $

> It's a generated file, and it sounds like it got
> mis-generated. There is possibly a broken Makefile rule that leaves it
> empty on errors or ^C: the rule is
>
>   quiet_cmd_mkregtable = MKREGTABLE $@
>         cmd_mkregtable = $(obj)/mkregtable $< > $@
>
> and if the 'mkregtable' binary is buggered, the above will leave an
> empty file around. And maybe your mkregtable failed to build earlier,
> leaving that empty file around and it will never fix itself up because
> of the "up-to-date" empty r200_reg_safe.h file.
>
> So removing the generated r200_reg_safe.h file

Removing just it doesn't change a lot.

> (and possibly the
> mkregtable binary) and trying again might fix it.

Removing mkregtable  has indeed the compile issue for me. Thanks!

> Which still leaves
> us with the question of how this happened, and a potentially fragile
> Makefile.
>
>                 Linus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/