Re: [RFC 3/6] drm: add SimpleDRM driver

From: David Herrmann
Date: Fri Jun 28 2013 - 06:00:10 EST


Hi

On Tue, Jun 25, 2013 at 3:05 AM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
> On 06/24/2013 03:27 PM, David Herrmann wrote:
>> + sdrm->fb_map = ioremap(sdrm->fb_base, sdrm->fb_size);
>
> This should probably be ioremap_wc. Otherwise it will be *really* slow
> if used in legacy mode and it may cause conflicts with the
> pgprot_writecombine mode for mmap.

Whoops, yepp, I fixed that.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/