Re: [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver

From: Samuel Ortiz
Date: Thu Jun 27 2013 - 17:48:38 EST


Hi Kevin,

On Thu, Jun 27, 2013 at 11:23:15AM -0700, Kevin Strasser wrote:
> Hi Wim,
>
> This driver hasn't received any further feedback. Are you ready to take it
> into watchdog-next, or do you still need to review it?
I applied the watchdog patch to mfd-next and got the following warning:

CC [M] drivers/watchdog/kempld_wdt.o
drivers/watchdog/kempld_wdt.c: In function âkempld_wdt_suspendâ:
drivers/watchdog/kempld_wdt.c:538:3: warning: passing argument 1 of
âkempld_wdt_stopâ from incompatible pointer type [enabled by default]
drivers/watchdog/kempld_wdt.c:313:12: note: expected âstruct
watchdog_device *â but argument is of type âstruct platform_device *â

I fixed it up, but I'd appreciate if you could double check that
kempld_wdt_suspend() is ok.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/