Re: [PATCH] Documentation: dt: bindings: TI WiLink modules
From: Nishanth Menon
Date: Thu Jun 27 2013 - 09:24:10 EST
On 06/27/2013 08:19 AM, Luciano Coelho wrote:
On Thu, 2013-06-27 at 08:15 -0500, Nishanth Menon wrote:
On Thu, Jun 27, 2013 at 7:58 AM, Luciano Coelho <coelho@xxxxxx> wrote:
For the actual DTS files, I could add a wilink.dtsi with enumerations
for these values so they could be used in the node definitions. But I'm
not sure it's going to be that valuable in the end.
The way GPIO HIGH was defined might help to provide guidance I think :)
Where? As far as I can see, the GPIO flags are defined in a bitmap.
include/dt-bindings/gpio/gpio.h
And corresponding kernel header:
include/linux/of_gpio.h
just a hint. not saying frequencies were defined in header. for systems
that define frequencies - example cpufreq OPPs, clock node usage, we do
not use indexing to frequency, instead, that is the responsibility of
driver to convert frequency back to required index.
git grep frequency Documentation/devicetree/bindings gives you how the
precedence looks like.
Personally, if given a choice, I'd go with actual frequencies rather
than indexes.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/