Re: [PATCH 12/15] perf tools: allow non-matching sample types

From: Adrian Hunter
Date: Thu Jun 27 2013 - 03:52:13 EST


On 25/06/13 15:32, Jiri Olsa wrote:
> On Mon, Jun 24, 2013 at 04:16:09PM +0300, Adrian Hunter wrote:
>> Sample types need not be identical to determine
>> the sample id from the event. Only the position
>> of the sample id needs to be the same.
>>
>> Compatible sample types are ones in which the bits
>> defined by PERF_COMPAT_MASK are the same.
>> 'perf_evlist__config()' forces sample types to be
>> compatible on that basis.
>
> hi,
> one of the patches is breaking test 4:
>
> [jolsa@krava perf]$ sudo ./perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect open syscall event : Ok
> 3: detect open syscall event on all cpus : Ok
> 4: read samples using the mmap interface :Can't parse sample, err = -14
> FAILED!
>
> haven't checked deeply, but my guess is this one ;-)

Thanks for testing. Fixed in V2.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/