Re: [PATCH 2/2] m68k/sun3: Dynamically allocate the table to trackIOMMU use

From: Geert Uytterhoeven
Date: Wed Jun 26 2013 - 11:00:23 EST


On Tue, Jun 25, 2013 at 9:42 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> -static unsigned long iommu_use[IOMMU_TOTAL_ENTRIES];
> +static unsigned long *iommu_use;
>
> #define dvma_index(baddr) ((baddr - DVMA_START) >> DVMA_PAGE_SHIFT)
>
> @@ -266,6 +267,7 @@ void __init dvma_init(void)
>
> list_add(&(hole->list), &hole_list);
>
> + iommu_use = alloc_bootmem(IOMMU_TOTAL_ENTRIES * sizeof(unsigned long));
> memset(iommu_use, 0, sizeof(iommu_use));

Bummer, the sizeof in the above line is no longer valid.
As the bootmem allocator zeroes memory, the line can just be removed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/