Re: [PATCH] TTY: memory leakage in tty_buffer_find()

[Peter Hurley]

On 06/26/2013 04:51 AM, channing wrote:
> In tty_buffer_find(), it scans all tty buffers in
> free buffer queue, if it finds matched one,
> tty->buf.free will point to matched one's next buffer,
> so tty buffers that ahead of matched one are removed
> from free queue, they will never be used but they
> are not released, then memory leak happen.

Actually, the whole scan loop is wrong: only tty buffers of
size 256 are added to the free list.

So this can't leak because a buffer will never be found
mid-list.

Greg has a patch series from me that reduces this but it's not
yet in next.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/