Re: [PATCH v2] pstore: Fail to unlink if a driver has not definedpstore_erase

[Aruna Balakrishnaiah]

On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote:
> On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> > On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
> > <aruna@xxxxxxxxxxxxxxxxxx> wrote:
> > > pstore_erase is used to erase the record from the persistent store.
> > > So if a driver has not defined pstore_erase callback return
> How do people manage devices like this?  With no erase function
> they just keep getting more and more pstore entries. Eventually
> they fill up.

We dont keep old records in the device. We have logs only of the
recent / last crash.  The device has a predefined space for each type
of messages.  For example:  Every time a crash occurs the data gets
overwritten in the device allocated to store crash log.

> > > Signed-off-by: Aruna Balakrishnaiah <aruna@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Applied - thanks.
>
> -Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/