Re: [PATCH] cfg80211/mac80211: fix doc compilation warnings

From: Johannes Berg
Date: Wed Jun 26 2013 - 03:37:27 EST


On Tue, 2013-06-25 at 21:48 +0200, Michael Opdenacker wrote:
> This patch fixes countless "No description found for parameter"
> warnings generating documentation (running "make htmldocs"),
> because the comments do not match the actual prototypes in the code.
>
> This issue didn't exist in 3.9. It may we worth fixing in 3.10
> (if it's not too late).

I think it's way late. Besides, all of this is already fixed in -next
trees.


> @@ -4153,6 +4153,7 @@ void cfg80211_report_wowlan_wakeup(struct wireless_dev *wdev,
> * cfg80211_crit_proto_stopped() - indicate critical protocol stopped by driver.
> *
> * @wdev: the wireless device for which critical protocol is stopped.
> + * @gfp: the type of memory to allocate (see kmalloc).

This is also wrong, the allocation flags don't really change the *type*
of memory, but only *how* it is allocated.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/