Re: [PATCH 15/15] perf tools: fix ppid in thread__fork()

From: David Ahern
Date: Tue Jun 25 2013 - 12:04:21 EST


On 6/25/13 10:00 AM, David Ahern wrote:
On 6/24/13 7:16 AM, Adrian Hunter wrote:
ppid should be assigned to the parents pid. Note
'thread__fork()'s only caller 'machine__process_fork_event()'
ensures that the parents pid is set.

Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
---
tools/perf/util/thread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index e3d4a55..93f3eab 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -85,7 +85,7 @@ int thread__fork(struct thread *self, struct thread
*parent)
if (map_groups__clone(&self->mg, &parent->mg, i) < 0)
return -ENOMEM;

- self->ppid = parent->tid;
+ self->ppid = parent->pid_;

Confused. My patch uses parent->pid and that it what I see in acme's
perf/core branch. When did this become parent->tid?

Never mind. Scanned the patch subjects too quickly and jumped over 2 to get to this one.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/