Re: [PATCH 4/5] perf tools: Introduce new -P/--parent-deep reportoption

From: Jiri Olsa
Date: Tue Jun 25 2013 - 11:35:27 EST


On Tue, Jun 25, 2013 at 08:18:26AM -0700, Andi Kleen wrote:
> On Tue, Jun 25, 2013 at 01:54:12PM +0200, Jiri Olsa wrote:
> > Introducing new -P/--parent-deep report option. It does the
> > same as '-p' but it force the deep search of the callchain
> > and looks for the deepest possible match.
>
> This doesn't make sense to me as an option.
>
> If it's a more correct callgraph it should be default, not
> an option.
>
> A option like "give me correct data" doesn't make sense.

I thought the '-p' behaviour was for a reason not a bug,
but I can change it to do the deep search and dont add '-P'

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/