Re: [PATCH] clk: Handle CLK_GET_RATE_NOCACHE flag in clk_set_rate()

From: Sylwester Nawrocki
Date: Mon Jun 24 2013 - 14:42:44 EST


On 06/21/2013 06:16 PM, Mike Turquette wrote:
> Quoting Sylwester Nawrocki (2013-06-21 06:07:35)
>> > If a clock has CLK_GET_RATE_NOCACHE flag set the rate needs to
>> > be recalculated, rather than referencing the cached value.
>> >
>> > Currently cached clk->rate is compared with new value to see if
>> > anything needs to be done in clk_set_rate(). This may cause required
>> > clock controller registers update to not happen when same clock
>> > frequency value is being set subsequently.
>> >
>> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>
> Peter already sent a patch for this:
> https://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commitdiff;h=34e452a152efd25d654b7bc809df429337115b03

Thanks Mike, that also helps. My apologies for not having
it noticed earlier. I'm going to post a patch for the Exynos
clock driver, which adds missing CLK_GET_RATE_NOCACHE flags to
the ISP clock group and would be really effective together
with the above one.

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/