Re: MTRR use in drivers

From: Dave Airlie
Date: Sun Jun 23 2013 - 17:27:24 EST


On Mon, Jun 24, 2013 at 6:58 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 06/23/2013 01:54 PM, Dave Airlie wrote:
>>>> breaking old boxes just because, is just going to get reverted when I
>>>> get the first regression report that you broke old boxes.
>>>>
>>>
>>> Not "just because", but *if* the choice is between breaking old boxes
>>> and breaking new boxes I'll take the latter.
>>>
>>
>> But Linus won't so your choice doesn't matter.
>
> I hate to break it to you, but we regress on ancient hardware all the
> time. Optimization work gets done on modern machines, so the sweet spot
> keeps moving. In particular, if supporting ancient hardware means
> leaving a lot of performance on modern hardware on the table, we may
> have to take that penalty.
>
> Fortunately, most of the time we don't have to.

Big difference between optimization sweet-spot and deliberately
breaking older systems. This is firmly in the second category, lots of
Intel hardware stops being useable when MTRR and PAT isn't working,
so much so we had to a warning to the driver when we detect such a thing.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/