Re: [PATCH][GIT PULL] trace,x86: Move creation of irq tracepointsfrom apic.c to irq.c

From: H. Peter Anvin
Date: Fri Jun 21 2013 - 17:54:18 EST


On 06/21/2013 02:28 PM, Steven Rostedt wrote:
> On Fri, 2013-06-21 at 14:13 -0700, H. Peter Anvin wrote:
>> On 06/21/2013 02:09 PM, Steven Rostedt wrote:
>>> Call Trace:
>>> [<ffffffff8103539d>] do_fork+0xa8/0x260
>>> [<ffffffff810ca7b1>] ? trace_preempt_on+0x2a/0x2f
>>> [<ffffffff812afb3e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
>>
>> This bit of the call chain seems a little odd, no?
>
> Doesn't the "?" mean its just in the stack but not part of the call
> frame that was used. CONFIG_FRAME_POINTER is set in the config.
>
> With lockdep and preempt tracing enabled, why would this seem strange?
>

I didn't think trace_hardirqs_on_thunk called trace_preempt_on but maybe
I misread the code.

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/