Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

From: Mathias Krause
Date: Thu Jun 20 2013 - 13:40:26 EST


On 16 June 2013 04:35, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> Mathias Krause <minipli@xxxxxxxxxxxxxx> writes:
>> If we pass a pointer to a const string in the form "module:symbol"
>> module_kallsyms_lookup_name() will try to split the string at the colon,
>> i.e., will try to modify r/o data. That will, in fact, fail on a kernel
>> with enabled CONFIG_DEBUG_RODATA.
>>
>> Avoid modifying the passed string in module_kallsyms_lookup_name(),
>> modify find_module_all() instead to pass it the module name length.
>>
>> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
>
> Applied, thanks.

Mind to push it to
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git#modules-next
as well, so it'll be included in linux-next?

Thanks,
Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/