Re: [PATCH] trace: using strlcpy instead of strncpy

From: Steven Rostedt
Date: Thu Jun 20 2013 - 08:20:12 EST


This fix is to a networking tracepoint. It should go through the
networking folks.

-- Steve


On Thu, 2013-06-20 at 19:07 +0800, Zhao Hongjiang wrote:
> for NUL terminated string, need alway set '\0' in the end.
>
> Signed-off-by: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
> ---
> include/trace/events/sock.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
> index 779abb9..333d8b5 100644
> --- a/include/trace/events/sock.h
> +++ b/include/trace/events/sock.h
> @@ -44,7 +44,7 @@ TRACE_EVENT(sock_exceed_buf_limit,
> ),
>
> TP_fast_assign(
> - strncpy(__entry->name, prot->name, 32);
> + strlcpy(__entry->name, prot->name, 32);
> __entry->sysctl_mem = prot->sysctl_mem;
> __entry->allocated = allocated;
> __entry->sysctl_rmem = prot->sysctl_rmem[0];


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/