Re: [PATCH 2/2] pinctrl: abx500: fix abx500_gpio_get()

[Patrice Chotard]

On Thu, Jun 20, 2013 at 11:00 AM, Fabio Baltieri
<fabio.baltieri@xxxxxxxxxx> wrote:
> Hi Patrice,
>
> On Thu, Jun 20, 2013 at 09:24:44AM +0200, patrice.chotard.st@xxxxxxxxx wrote:
>> From: Patrice Chotard <patrice.chotard@xxxxxx>
>>
>> _ allow to get output GPIO value.
>> _ as there is no GPIO0 on ABX500, use correct offset with
>>   abx500_gpio_get_bit().
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxx>
>> ---
>>  drivers/pinctrl/pinctrl-abx500.c |   16 ++++++++++++++--
>>  1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
>> index 4307b0f..070442d 100644
>> --- a/drivers/pinctrl/pinctrl-abx500.c
>> +++ b/drivers/pinctrl/pinctrl-abx500.c
>> @@ -162,10 +162,22 @@ static int abx500_gpio_get(struct gpio_chip *chip, unsigned offset)
>>  {
>>       struct abx500_pinctrl *pct = to_abx500_pinctrl(chip);
>>       bool bit;
>> +     bool is_out;
>> +     u8 gpio_offset = offset - 1;
>>       int ret;
>>
>> -     ret = abx500_gpio_get_bit(chip, AB8500_GPIO_IN1_REG,
>> -                               offset, &bit);
>> +     ret = abx500_gpio_get_bit(chip, AB8500_GPIO_DIR1_REG, gpio_offset, &is_out);
>> +     if (ret < 0) {
>> +             dev_err(pct->dev, "%s failed\n", __func__);
>> +             return ret;
>> +     }
>> +
>> +     if (is_out)
>> +             ret = abx500_gpio_get_bit(chip, AB8500_GPIO_OUT1_REG,
>> +                             gpio_offset, &bit);
>> +     else
>> +             ret = abx500_gpio_get_bit(chip, AB8500_GPIO_IN1_REG,
>> +                             gpio_offset, &bit);
>
> Why would you want to read the pin state from the output register?  The
> input one should be the one that reflect the real electrical value of
> the pin, and I think it may be useful to detect some fault condition
> too...  Is there a specific reasion to use the output register instead?
>
Hi Fabio

I want to read the pin state from the output register for debugfs print out.
In abx500_gpio_dbg_show_one(), chip->get() is used to retrieve the output
pin's level.

Patrice

> Thanks,
> Fabio
>
>>       if (ret < 0) {
>>               dev_err(pct->dev, "%s failed\n", __func__);
>>               return ret;
>> --
>> 1.7.10
>>
>
> --
> Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/