Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

From: Chen Gang
Date: Thu Jun 20 2013 - 04:27:39 EST


On 06/20/2013 03:47 PM, Thomas Gleixner wrote:
> On Tue, 18 Jun 2013, Chen Gang wrote:
>> > On 06/10/2013 10:12 PM, Thomas Gleixner wrote:
>> > I think we can treat original implementation as for speed optimization,
>> > so our discussion is "whether this speed optimization has effect with
>> > correctness".
> Then I recommend that you to sit down and analyze the correctness of
> the code.

That is only your recommend, not mean I have duty to.

>
> Come back when you have a proof of the code being wrong. And by proof
> I mean factual proof not just handwaving theories.


At least before say so, please reply:

-------------------------------------------------------------------------------
If we assume "If there is nothing in tv2 which might come before the
found timer, then any timer in tv3 will ..." is correct.

When we found a timer in 'tv1', we will not search all timers in 'tv2'
(we only search first looping of tv2 for the specific 'slot').

Is it still OK ?
-------------------------------------------------------------------------------


If you do not want to discuss with others, better quite politely, not
need judging or checking others, it is useless for the cooperation with
each other, is it right ? ;-)


Thanks.
--
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/