Re: [PATCH 3/3] perf tools: include termios.h explicitly

[Joonsoo Kim]

On Wed, Jun 19, 2013 at 09:16:20PM +0900, Namhyung Kim wrote:
> Hi Ingo,
> 
> On Wed, Jun 19, 2013 at 8:33 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > * Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote:
> >
> >> Building perf for android is failed, because it can't find definition of
> >> struct winsize. This definition is in termios.h, so I add this header
> >> to util.h to solve the problem. It is missed by commit '2c803e52' which
> >> moves get_term_dimensions() from builtin-top.c to util.c, but, missed to
> >> move termios.h header.
> >>
> >> Cc: David Ahern <dsahern@xxxxxxxxx>
> >> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> >> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> >
> > Is this something we need for v3.10 as well?
> >
> > Thanks,
> >
> >         Ingo
> 
> I think it's good to go to v3.10 and even v3.9 as well:
> 
>  $ git name-rev --tags --refs=refs/tags/v3.* 2c803e52
>  2c803e52 tags/v3.9-rc1~173^2~13^2~22

Agreed.

> 
> --
> Thanks,
> Namhyung
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/