Re: [PATCH 2/2] USB: serial: ti_usb_3410_5052: Be explicit about theAbbott product ids being product ids.

From: Greg KH
Date: Wed Jun 19 2013 - 18:52:13 EST


On Wed, Jun 19, 2013 at 01:58:49AM +0200, Anders Hammarquist wrote:
> Be explicit about the Abbott product ids being product ids.
>
> Signed-off-by: Anders Hammarquist <iko@xxxxxxxxx>
> ---
> drivers/usb/serial/ti_usb_3410_5052.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.h b/drivers/usb/serial/ti_usb_3410_5052.h
> index 4a2423e..ea8b273 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.h
> +++ b/drivers/usb/serial/ti_usb_3410_5052.h
> @@ -52,9 +52,9 @@
>
> /* Abbott Diabetics vendor and product ids */
> #define ABBOTT_VENDOR_ID 0x1a61
> -#define ABBOTT_STEREO_PLUG_ID 0x3410
> +#define ABBOTT_STEREO_PLUG_PRODUCT_ID 0x3410
> #define ABBOTT_PRODUCT_ID ABBOTT_STEREO_PLUG_ID

Can you just delete ABBOTT_PRODUCT_ID here, because if you ever use it,
you will get a build error, right?

I'll just take the first patch for now, please resend this one.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/