Re: [PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

[Grygorii Strashko]

Hi Felipe,

On 06/07/2013 10:07 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote:
> > The omap_i2c_isr() does the irq check and schedules threaded handler if any of
> > enabled IRQs is active, but currently the I2C IRQs are enabled just once,
> > when I2C IP is enabling (transfer started) and they aren't changed after that.
> > More over, now the I2C INTC IRQ is disabled when I2C IP is idled.
> > Thus, I2C IRQs will start coming only when we want that, and there is
> > no sense to have omap_i2c_isr() anymore:
> so ? we still want to check if this device generated IRQs in hardirq
> context. What if the IRQ line is shared ?
Pleas see, https://patchwork.kernel.org/patch/2689211/
[1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

It covers shared IRQ problem

Sorry, for delayed reply - I've had problems with my e-mail.

- grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/