Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

[Kevin Strasser]

On Wed, Jun 19, 2013 at 11:12:09AM +0200, Thomas Gleixner wrote:
> On Tue, 18 Jun 2013, Kevin Strasser wrote:
> 
> This patch set looks reasonable now, except a formal issue.
>  
> > Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
> > Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> 
> This is wrong, as it says:
> 
>  Kevin authored the code, sent it to Michael and Michael sent it to
>  LKML.
> 
> 
> The original code was authored by Michael. This version was authored
> by Kevin based on Michaels code.
> 
> So either you keep Michael as the author, then you want 
> 
>  From: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> 
>  <patch description/>
> 
>  Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
>  Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
> 
> or you decide that it's a major rewrite by you, then you want:
> 
>  This patch is based on the original version authored by
>  Michael Brunner <michael.brunner@xxxxxxxxxxx>.
> 
>  Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
> 
>  Or 
> 
>  Originally-From: Michael Brunner <michael.brunner@xxxxxxxxxxx>.
>  Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>

Ok, I think this will make sense for all the patches except gpio,
which is a major rewrite by Guenter.

So maybe this would be appropriate:

 From: Guenter Roeck <linux@xxxxxxxxxxxx>

 <patch description>

 Originally-From: Michael Brunner <michael.brunner@xxxxxxxxxxx>
 Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
 Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
 ...

Thanks,
Kevin

> 
> Other than that.
> 
> Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/