Re: [PATCH percpu/for-3.11 1/2] percpu-refcount: add __must_check topercpu_ref_init() and don't use ACCESS_ONCE() in percpu_ref_kill_rcu()
From: Tejun Heo
Date: Wed Jun 19 2013 - 04:22:15 EST
On Wed, Jun 19, 2013 at 12:25:14PM +0930, Rusty Russell wrote:
> But it's quite OK to ignore OOM errors in builtin init functions.
I think it'd be cleaner to let those use cases use BUG_ON() around it.
We really want most users to be checking its return value.
> It would be neatest to have it fail into slow mode, of course, but it's
> probably not worth the pain.
percpu allocation is always GFP_KERNEL, so it can't get any slower
without deadlocking.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/